davidradl commented on code in PR #26781:
URL: https://github.com/apache/flink/pull/26781#discussion_r2200070425


##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java:
##########
@@ -290,7 +292,7 @@ public Set<String> listDatabases(String catalogName) {
     public Set<TableInfo> listTables(
             String catalogName, String databaseName, Set<TableKind> 
tableKinds) {
         checkArgument(
-                Arrays.asList(TableKind.TABLE, 
TableKind.VIEW).containsAll(tableKinds),
+                EnumSet.of(TableKind.TABLE, 
TableKind.VIEW).containsAll(tableKinds),
                 "Currently only support to list TABLE, VIEW or TABLE AND 
VIEW.");

Review Comment:
   nit: English not great. I suggest
   `Currently only supports listing TABLE, VIEW or TABLE AND VIEW.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to