nishita-09 commented on code in PR #994:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/994#discussion_r2204298193
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/SessionReconciler.java:
##########
@@ -120,6 +126,61 @@ private void
recoverSession(FlinkResourceContext<FlinkDeployment> ctx) throws Ex
.setJobManagerDeploymentStatus(JobManagerDeploymentStatus.DEPLOYING);
}
+ /**
+ * Detects unmanaged jobs running in the session cluster. Unmanaged jobs
are jobs that exist in
+ * the Flink cluster but are not managed by FlinkSessionJob resources.
+ */
+ private Set<JobID> getUnmanagedJobs(
+ FlinkResourceContext<FlinkDeployment> ctx, Set<FlinkSessionJob>
sessionJobs) {
Review Comment:
@gyfora I have pushed another commit to address the comments here. I have
stuck with getNonTerminalJobIds() to ensure the Event contains the list of job
IDs that are not terminated for better observability for the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
