davidradl commented on code in PR #26797:
URL: https://github.com/apache/flink/pull/26797#discussion_r2206819488


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java:
##########
@@ -114,15 +111,18 @@ public <T> DataType createRawDataType(TypeInformation<T> 
typeInfo) {
     @Override
     public LogicalType createLogicalType(String typeString) {
         final LogicalType parsedType = LogicalTypeParser.parse(typeString, 
classLoader);
-        return parsedType.accept(resolver);
+        if (LogicalTypeChecks.hasNested(parsedType, t -> 
t.is(LogicalTypeRoot.UNRESOLVED))) {
+            throw unsupportedUserDefinedTypes();

Review Comment:
   nit: I realise this is a backport. I was wondering if it would be better to 
include the failing typeString as an insert in the Exception message to help 
diagnostics?  WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to