wenjin272 commented on PR #71: URL: https://github.com/apache/flink-agents/pull/71#issuecomment-3088807364
Hi, @kitalkuyo-gita, thanks for your contribution, but there are some basic issues should be settled before we talk about the detail of this PR. 1. I think this PR is not consistent with our design #41 , which Resource is the abstract of Tool, Prompt, VectorStore and so on, and ResourceProvider is used to create/get Resource in runtime. 2. We should keep the compatibility between Python and Java API. You can refer #70, which introduce Resource & Resource Provider in python. 3. There should not be any Chinese comment in the source code. 4. There are code style check failure and test case failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
