pnowojski commented on PR #26861: URL: https://github.com/apache/flink/pull/26861#issuecomment-3174508345
There were two more test failures. One fixed by [[FLINK-38180][test] Rewrite testWithRocksDbBackendIncremental to not depend on close not being called on failures](https://github.com/apache/flink/pull/26861/commits/cefbf94b9d989b39eaf5ffc586502db1704b84d7) due to an incorrect test assertion Another one fixed by: [[FLINK-38180][table] Safeguard bunch of code generated operators from throwing NPE on close](https://github.com/apache/flink/pull/26861/commits/8576c6b8d970061b2f180e14272ee5ba2c275452) Due to NPE during task cancellation: ``` java.lang.NullPointerException: Cannot invoke "org.apache.flink.table.runtime.util.collections.binary.AbstractBytesHashMap.free()" because "this.aggregateMap$8" is null at LocalHashAggregateWithKeys$133.close(Unknown Source) ~[?:?] at org.apache.flink.streaming.runtime.tasks.StreamOperatorWrapper.close(StreamOperatorWrapper.java:163) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.streaming.runtime.tasks.RegularOperatorChain.closeAllOperators(RegularOperatorChain.java:125) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.streaming.runtime.tasks.StreamTask.closeAllOperators(StreamTask.java:1197) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.util.IOUtils.closeAll(IOUtils.java:257) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.core.fs.AutoCloseableRegistry.doClose(AutoCloseableRegistry.java:72) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.util.AbstractAutoCloseableRegistry.close(AbstractAutoCloseableRegistry.java:127) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.streaming.runtime.tasks.StreamTask.cleanUp(StreamTask.java:1101) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.runtime.taskmanager.Task.lambda$restoreAndInvoke$0(Task.java:950) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:965) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.runtime.taskmanager.Task.lambda$restoreAndInvoke$1(Task.java:950) [flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.util.IOUtils.closeAll(IOUtils.java:257) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.core.fs.AutoCloseableRegistry.doClose(AutoCloseableRegistry.java:72) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.util.AbstractAutoCloseableRegistry.close(AbstractAutoCloseableRegistry.java:127) ~[flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:833) [flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at org.apache.flink.runtime.taskmanager.Task.run(Task.java:569) [flink-dist-2.2-SNAPSHOT.jar:2.2-SNAPSHOT] at java.base/java.lang.Thread.run(Thread.java:840) [?:?] ``` causing whole TM to fail over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
