aws-nageshvh commented on code in PR #201:
URL:
https://github.com/apache/flink-connector-aws/pull/201#discussion_r2274832184
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java:
##########
@@ -244,34 +314,121 @@ private void handleFullyFailedRequest(
@Override
public void close() {
- AWSGeneralUtil.closeResources(httpClient, kinesisClient);
+ try {
+ kinesisClientProvider.close();
+ } catch (IOException e) {
+ throw new RuntimeException("Failed to close the
kinesisClientProvider", e);
Review Comment:
I found there was a common exception so replaced it with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
