snuyanzin commented on code in PR #27003:
URL: https://github.com/apache/flink/pull/27003#discussion_r2359489199
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##########
@@ -708,7 +708,7 @@ public ContextResolvedTable
getTableOrError(ObjectIdentifier objectIdentifier) {
return getTable(objectIdentifier)
.orElseThrow(
() ->
- new TableException(
+ new ValidationException(
Review Comment:
>I would associate a validation error as something incorrect or inconsistent
with the definition.
it has a pretty straightforward definition: `Exception for all errors
occurring during validation phase. `
>For me attempting to get a table that does not exist is not a validation
error or something that occurs in the validation phase.
then when?
Before execution there is a validation phase which among others does
validations against catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
