Izeren commented on code in PR #27833:
URL: https://github.com/apache/flink/pull/27833#discussion_r2993699910
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3Committer.java:
##########
@@ -39,6 +40,7 @@
* <p>The "empty parts" check is a defensive measure against programming
errors - in normal
* operation, a multipart upload should always have at least one part before
committing.
*/
+@Experimental
public class NativeS3Committer implements
RecoverableFsDataOutputStream.Committer {
Review Comment:
Do we need this class to be public?
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3RecoverableFsDataOutputStream.java:
##########
@@ -50,6 +51,7 @@
* #closeForCommit()}, and {@link #persist()} to ensure safe cleanup of local
resources without
* corrupting S3 state.
*/
+@Experimental
@NotThreadSafe
public class NativeS3RecoverableFsDataOutputStream extends
RecoverableFsDataOutputStream {
Review Comment:
Same
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3OutputStream.java:
##########
@@ -42,6 +43,7 @@
* can be safely invoked from another thread (e.g. during task cancellation)
per {@link
* org.apache.flink.core.fs.FSDataOutputStream} contract.
*/
+@Experimental
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
