xuyangzhong commented on PR #27838: URL: https://github.com/apache/flink/pull/27838#issuecomment-4140615675
> @xuyangzhong +1 for the optimization! I left some comments there. > > For the tests, we should add at least one test case triggering the DELETE_BY_KEY path with immutable columns. Currently, immutable cols cannot be defined on sources that output rowkind `DELETE`, making it difficult to add tests. Therefore, I've decided to abandon this approach and revert the changes to SatisfyDeleteKindTraitVisitor, focusing only on modifications to SatisfyUpdateKindTraitVisitor. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
