wenjin272 commented on code in PR #579:
URL: https://github.com/apache/flink-agents/pull/579#discussion_r3007237440
##########
.github/workflows/ci.yml:
##########
@@ -47,6 +47,10 @@ jobs:
echo "$HOME/.local/bin" >> $GITHUB_PATH
- name: Check code style
run: ./tools/lint.sh -c
+ - name: Check ResourceName consistency (Java vs Python)
Review Comment:
I think that placing consistency checks for resource names within code style
checks is not entirely appropriate, because code style typically refers to the
checking of coding conventions and rules within a single language. I think it
is more appropriate to include it in the cross-language test.
##########
python/pyproject.toml:
##########
@@ -86,6 +86,8 @@ build = [
# Test dependencies
test = [
"pytest==8.4.0",
+ "apache-flink>=1.20",
+ "cloudpickle",
Review Comment:
If the consistency check for resource names is moved to the cross-language
test, these additional dependencies are unnecessary because we manually install
apache-flink in `tools/e2e.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
