featzhang commented on code in PR #27700:
URL: https://github.com/apache/flink/pull/27700#discussion_r3008135365
##########
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##########
@@ -224,6 +224,12 @@ under the License.
<pattern>org.apache.flink.runtime.util</pattern>
<shadedPattern>org.apache.flink.fs.gs.org.apache.flink.runtime.util</shadedPattern>
</relocation>
+ <!-- Relocate
Jackson to prevent conflicts with user jobs that depend on newer
+ Jackson
versions. -->
+ <relocation>
Review Comment:
Please double-check whether org.apache.flink.fs.gs.shaded.jackson stays
isolated from existing relocated Google dependency trees, since GCS connector
already contains several shaded transitive libraries and overlapping relocation
prefixes may complicate debugging.
##########
flink-filesystems/flink-azure-fs-hadoop/pom.xml:
##########
@@ -150,6 +150,12 @@ under the License.
<pattern>org.apache.flink.runtime.util</pattern>
<shadedPattern>org.apache.flink.fs.azure.common</shadedPattern>
</relocation>
+ <!-- Relocate
Jackson to prevent conflicts with user jobs that depend on newer
+ Jackson
versions. -->
+ <relocation>
Review Comment:
It may be worth adding a short note explaining why plugin-local shading is
preferred over reusing an existing Flink-wide shaded Jackson namespace, to make
future maintenance easier.
##########
flink-filesystems/flink-azure-fs-hadoop/pom.xml:
##########
@@ -150,6 +150,12 @@ under the License.
<pattern>org.apache.flink.runtime.util</pattern>
<shadedPattern>org.apache.flink.fs.azure.common</shadedPattern>
</relocation>
+ <!-- Relocate
Jackson to prevent conflicts with user jobs that depend on newer
Review Comment:
Consider verifying whether relocating the full com.fasterxml.jackson
namespace is broader than required here. Some Azure SDK transitive dependencies
may rely on Jackson service metadata (META-INF/services) or module discovery,
and full relocation can occasionally affect runtime compatibility if resource
transformers are not aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
