ldadima commented on code in PR #27839:
URL: https://github.com/apache/flink/pull/27839#discussion_r3013383091
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java:
##########
@@ -368,6 +368,16 @@ public class OptimizerConfigOptions {
+ "These might break
savepoint compatibility across Flink versions and the goal is to have a stable
version in the next release.")
.build());
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_OPTIMIZER_USE_MULTI_JOIN_FOR_BINARY_JOIN =
+ key("table.optimizer.multi-join.use-for-binary-join")
+ .booleanType()
+ .defaultValue(false)
Review Comment:
There is no full certainty yet that a multi join with 2 inputs is always
worse. False - the default value, as within the nexmark queries no benefits
were observed in BinaryMultiJoin
Also, it occurred to me that the option would add more flexibility in using
multi join optimization. But, in principle, I do not consider the addition of
this option to be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
