Copilot commented on code in PR #4356:
URL: https://github.com/apache/flink-cdc/pull/4356#discussion_r3014468524
##########
docs/content/docs/connectors/flink-sources/mysql-cdc.md:
##########
@@ -48,7 +48,7 @@ In order to setup the MySQL CDC connector, the following
table provides dependen
```Download link is available only for stable releases.```
-Download [flink-sql-connector-mysql-cdc-{{< param Version
>}}.jar](https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-mysql-cdc/{{<
param Version >}}/flink-sql-connector-mysql-cdc-{{< param Version >}}.jar) and
put it under `<FLINK_HOME>/lib/`.
+Download
[flink-sql-connector-mysql-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-mysql-cdc)
and put it under `<FLINK_HOME>/lib/`.
Review Comment:
PR description says the "download links only available" notice was removed
from mysql-cdc.md, but the notice ("Download link is available only for stable
releases.") is still present above the updated mvnrepository link. Either
update the PR description to match the actual change, or remove/update the
notice text here if it's no longer needed with artifact-page links.
##########
docs/content/docs/connectors/flink-sources/overview.md:
##########
@@ -81,15 +81,15 @@ The following table shows the current features of the
connector:
| Connector
| No-lock Read | Parallel Read | Exactly-once Read | Incremental
Snapshot Read |
|---------------------------------------------------------------------------------------|--------------|---------------|-------------------|---------------------------|
-| [mongodb-cdc]({{< ref "docs/connectors/flink-sources/mongodb-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [mysql-cdc]({{< ref "docs/connectors/flink-sources/mysql-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [oracle-cdc]({{< ref "docs/connectors/flink-sources/oracle-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [postgres-cdc]({{< ref "docs/connectors/flink-sources/postgres-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [sqlserver-cdc]({{< ref "docs/connectors/flink-sources/sqlserver-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [oceanbase-cdc]({{< ref "docs/connectors/flink-sources/oceanbase-cdc" >}}) |
❌ | ❌ | ❌ | ❌ |
-| [tidb-cdc]({{< ref "docs/connectors/flink-sources/tidb-cdc" >}}) |
✅ | ❌ | ✅ | ❌ |
-| [db2-cdc]({{< ref "docs/connectors/flink-sources/db2-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [vitess-cdc]({{< ref "docs/connectors/flink-sources/vitess-cdc" >}}) |
✅ | ❌ | ✅ | ❌ |
+| [mongodb-cdc]({{< ref "docs/connectors/flink-sources/mongodb-cdc" >}}) |
✅ | ✅ |
[mongodb-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-mongodb-cdc)
| ✅ |
+| [mysql-cdc]({{< ref "docs/connectors/flink-sources/mysql-cdc" >}}) |
✅ | ✅ |
[mysql-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-mysql-cdc)
| ✅ |
+| [oracle-cdc]({{< ref "docs/connectors/flink-sources/oracle-cdc" >}}) |
✅ | ✅ |
[oracle-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-oracle-cdc)
| ✅ |
+| [postgres-cdc]({{< ref "docs/connectors/flink-sources/postgres-cdc" >}}) |
✅ | ✅ |
[postgres-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-postgres-cdc)
| ✅ |
+| [sqlserver-cdc]({{< ref "docs/connectors/flink-sources/sqlserver-cdc" >}}) |
✅ | ✅ |
[sqlserver-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-sqlserver-cdc)
| ✅ |
+| [oceanbase-cdc]({{< ref "docs/connectors/flink-sources/oceanbase-cdc" >}}) |
❌ | ❌ |
[oceanbase-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-oceanbase-cdc)
| ❌ |
+| [tidb-cdc]({{< ref "docs/connectors/flink-sources/tidb-cdc" >}}) |
✅ | ❌ |
[tidb-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-tidb-cdc)
| ❌ |
+| [db2-cdc]({{< ref "docs/connectors/flink-sources/db2-cdc" >}}) |
✅ | ✅ |
[db2-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-db2-cdc)
| ✅ |
+| [vitess-cdc]({{< ref "docs/connectors/flink-sources/vitess-cdc" >}}) |
✅ | ❌ |
[vitess-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-vitess-cdc)
| ❌ |
Review Comment:
The "Features" table's "Exactly-once Read" column is no longer a boolean
indicator: it now contains mvnrepository download links, which breaks the table
semantics and misrepresents the capability matrix. The download links belong in
the earlier "Supported Connectors" table; this column should remain ✅/❌ (and
the mvnrepository link should not be in this feature matrix).
##########
docs/content/docs/connectors/flink-sources/oceanbase-cdc.md:
##########
@@ -108,7 +108,7 @@ In order to set up the OceanBase CDC connector, the
following table provides dep
```Download link is available only for stable releases.```
-Download [flink-sql-connector-oceanbase-cdc-{{< param Version
>}}.jar](https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-oceanbase-cdc/{{<
param Version >}}/flink-sql-connector-oceanbase-cdc-{{< param Version >}}.jar)
and put it under `<FLINK_HOME>/lib/`.
+Download
[flink-sql-connector-oceanbase-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-oceanbase-cdc)
and put it under `<FLINK_HOME>/lib/`.
Review Comment:
PR description says the "download links only available" notice was removed
from oceanbase-cdc.md, but the notice ("Download link is available only for
stable releases.") is still present above the updated mvnrepository link.
Please either adjust the PR description or remove/update this notice to keep
the documentation consistent.
##########
docs/content.zh/docs/connectors/flink-sources/overview.md:
##########
@@ -81,15 +81,15 @@ The following table shows the current features of the
connector:
| Connector |
No-lock Read | Parallel Read | Exactly-once Read | Incremental Snapshot Read |
|----------------------------------------------------------------------------|--------------|---------------|-------------------|---------------------------|
-| [mongodb-cdc]({{< ref "docs/connectors/flink-sources/mongodb-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [mysql-cdc]({{< ref "docs/connectors/flink-sources/mysql-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [oracle-cdc]({{< ref "docs/connectors/flink-sources/oracle-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [postgres-cdc]({{< ref "docs/connectors/flink-sources/postgres-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [sqlserver-cdc]({{< ref "docs/connectors/flink-sources/sqlserver-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [oceanbase-cdc]({{< ref "docs/connectors/flink-sources/oceanbase-cdc" >}}) |
❌ | ❌ | ❌ | ❌ |
-| [tidb-cdc]({{< ref "docs/connectors/flink-sources/tidb-cdc" >}}) |
✅ | ❌ | ✅ | ❌ |
-| [db2-cdc]({{< ref "docs/connectors/flink-sources/db2-cdc" >}}) |
✅ | ✅ | ✅ | ✅ |
-| [vitess-cdc]({{< ref "docs/connectors/flink-sources/vitess-cdc" >}}) |
✅ | ❌ | ✅ | ❌ |
+| [mongodb-cdc]({{< ref "docs/connectors/flink-sources/mongodb-cdc" >}}) |
✅ | ✅ |
[mongodb-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-mongodb-cdc)
| ✅ |
+| [mysql-cdc]({{< ref "docs/connectors/flink-sources/mysql-cdc" >}}) |
✅ | ✅ |
[mysql-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-mysql-cdc)
| ✅ |
+| [oracle-cdc]({{< ref "docs/connectors/flink-sources/oracle-cdc" >}}) |
✅ | ✅ |
[oracle-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-oracle-cdc)
| ✅ |
+| [postgres-cdc]({{< ref "docs/connectors/flink-sources/postgres-cdc" >}}) |
✅ | ✅ |
[postgres-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-postgres-cdc)
| ✅ |
+| [sqlserver-cdc]({{< ref "docs/connectors/flink-sources/sqlserver-cdc" >}}) |
✅ | ✅ |
[sqlserver-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-sqlserver-cdc)
| ✅ |
+| [oceanbase-cdc]({{< ref "docs/connectors/flink-sources/oceanbase-cdc" >}}) |
❌ | ❌ |
[oceanbase-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-oceanbase-cdc)
| ❌ |
+| [tidb-cdc]({{< ref "docs/connectors/flink-sources/tidb-cdc" >}}) |
✅ | ❌ |
[tidb-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-tidb-cdc)
| ❌ |
+| [db2-cdc]({{< ref "docs/connectors/flink-sources/db2-cdc" >}}) |
✅ | ✅ |
[db2-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-db2-cdc)
| ✅ |
+| [vitess-cdc]({{< ref "docs/connectors/flink-sources/vitess-cdc" >}}) |
✅ | ❌ |
[vitess-cdc](https://mvnrepository.com/artifact/org.apache.flink/flink-sql-connector-vitess-cdc)
| ❌ |
Review Comment:
Same issue as the English version: in the "Features" table, the
"Exactly-once Read" column was replaced with mvnrepository links, so it no
longer shows ✅/❌ and the capability matrix becomes incorrect. Keep this column
as a boolean feature indicator and keep download links only in the connector
download section/table.
```suggestion
| [postgres-cdc]({{< ref "docs/connectors/flink-sources/postgres-cdc" >}})
| ✅ | ✅ | ✅
| ✅ |
| [sqlserver-cdc]({{< ref "docs/connectors/flink-sources/sqlserver-cdc" >}})
| ✅ | ✅ | ✅
| ✅ |
| [oceanbase-cdc]({{< ref "docs/connectors/flink-sources/oceanbase-cdc" >}})
| ❌ | ❌ | ❌
| ❌ |
| [tidb-cdc]({{< ref "docs/connectors/flink-sources/tidb-cdc" >}})
| ✅ | ❌ | ❌
| ❌ |
| [db2-cdc]({{< ref "docs/connectors/flink-sources/db2-cdc" >}})
| ✅ | ✅ | ✅
| ✅ |
| [vitess-cdc]({{< ref "docs/connectors/flink-sources/vitess-cdc" >}})
| ✅ | ❌ | ❌
| ❌ |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
