Dennis-Mircea commented on PR #1077:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/1077#issuecomment-4165301559

   > Thanks for the PR @Dennis-Mircea! The PR description and the JIRA issue, 
while very elaborate (the JIRA reads like a research paper), do not contain a 
clear description of the problem and the approach we chose to solve it. I think 
we should take one step at a time. If we are solving multiple problems, it 
would be good to break them down into separate PRs.
   
   Thanks for the feedback @mxm! You're right, the original PR was doing too 
much.
   
   I've stripped it down to a single fix for now: direction-safety guards for 
the parallelism alignment logic. The current two-phase search in `scale()` 
could silently invert the scaling direction. For resolving this the current PR 
just adds two guards to prevent that. I also updated the JIRA to reflect this.
   
   Also, for the new scaling-mode enhancements (to give the autoscaler a more 
flexible way to scale source vertices), I’ll open a separate JIRA and follow-up 
PR to track that work.
   
   Please let me know if you're ok with this approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to