Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3023417776
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -247,13 +267,54 @@ public FileSystem create(URI fsUri) throws IOException {
String region = config.get(REGION);
String endpoint = config.get(ENDPOINT);
boolean pathStyleAccess = config.get(PATH_STYLE_ACCESS);
-
Review Comment:
Global access-key and secret-key are read at the beginning of `create()`
(lines 265-266 via config.get(ACCESS_KEY) and config.get(SECRET_KEY)).
These are then passed through to `S3ClientProvider.builder()`. The
bucket-level override at line 290-291 uses
`firstNonNull(overrides.getAccessKey(), accessKey)`, which falls back to the
global value when no bucket override is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
