gyfora commented on code in PR #1075:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1075#discussion_r3027559944
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -107,12 +109,16 @@ public void scale(Context ctx) throws Exception {
} catch (Throwable e) {
onError(ctx, autoscalerMetrics, e);
} finally {
- try {
- applyParallelismOverrides(ctx);
- applyConfigOverrides(ctx);
- } catch (Exception e) {
- LOG.error("Error applying overrides.", e);
- onError(ctx, autoscalerMetrics, e);
+ // Skip applying overrides when the job is not yet in a stable
running state,
+ // as they may have already been applied during the previous
scaling cycle.
+ if (!waiting) {
+ try {
+ applyParallelismOverrides(ctx);
+ applyConfigOverrides(ctx);
Review Comment:
Actually this makes me think, if the overrides are not applied that means
the reconciler will detect it as a change ?
Because it started an upgrade, last reconciled spec contains the overrides,
the job is not running yet and the overrides are not there now -> wouldn't it
try to reconcile it? sounds incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
