rmetzger commented on code in PR #243:
URL:
https://github.com/apache/flink-connector-kafka/pull/243#discussion_r3027757049
##########
docs/content/docs/connectors/table/kafka.md:
##########
@@ -233,7 +233,7 @@ Connector Options
<td style="word-wrap: break-word;">(none)</td>
<td>String</td>
<td>
- This can set and pass arbitrary Kafka configurations. Suffix names
must match the configuration key defined in <a
href="https://kafka.apache.org/documentation/#configuration";>Kafka
Configuration documentation</a>. Flink will remove the "properties." key prefix
and pass the transformed key and values to the underlying KafkaClient. For
example, you can disable automatic topic creation via
<code>'properties.allow.auto.create.topics' = 'false'</code>. But there are
some configurations that do not support to set, because Flink will override
them, e.g. <code>'auto.offset.reset'</code>.
+ This can set and pass arbitrary Kafka configurations. Suffix names
must match the configuration key defined in <a
href="https://kafka.apache.org/documentation/#configuration";>Kafka
Configuration documentation</a>. Flink will remove the "properties." key prefix
and pass the transformed key and values to the underlying KafkaClient. For
example, you can disable automatic topic creation via
<code>'properties.allow.auto.create.topics' = 'false'</code>. But there are
some configurations that do not support to set, because Flink will override
them, e.g. <code>'auto.offset.reset'</code>. However, when
<code>'scan.startup.mode'</code> is set to <code>'group-offsets'</code>,
<code>'properties.auto.offset.reset'</code> is supported and used as the
fallback strategy when no committed offsets exist for the consumer group.
</td>
Review Comment:
I thought we maintain the kafka connector docs in the connector repo and
copy it somehow into the Flink docs?
I really don't know, just be sure that this is not generated or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
