Au-Miner commented on code in PR #27894:
URL: https://github.com/apache/flink/pull/27894#discussion_r3039752710
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/LikeFunctionITCase.java:
##########
@@ -148,8 +148,22 @@ private Stream<TestSetSpec> withEscape() {
DataTypes.STRING(),
DataTypes.STRING())
// Empty strings in pattern or escape
- .testSqlResult("f0 LIKE 'test\"end' ESCAPE ''", false,
DataTypes.BOOLEAN())
.testSqlResult("f0 LIKE '' ESCAPE ''", false,
DataTypes.BOOLEAN())
+ .testSqlResult("f0 LIKE '' ESCAPE '!'", false,
DataTypes.BOOLEAN())
+ .testSqlResult("f0 LIKE 'test\"end' ESCAPE ''", false,
DataTypes.BOOLEAN())
+ // Escaped _ in quick path: startsWith (BEGIN_PATTERN)
+ .testSqlResult("f2 LIKE 'te!_%' ESCAPE '!'", true,
DataTypes.BOOLEAN())
+ .testSqlResult("f0 LIKE 'te!_%' ESCAPE '!'", false,
DataTypes.BOOLEAN())
+
+ // Escaped _ in quick path: endsWith (END_PATTERN)
+ .testSqlResult("f2 LIKE '%!_st' ESCAPE '!'", true,
DataTypes.BOOLEAN())
+
+ // Escaped _ in quick path: contains (MIDDLE_PATTERN)
+ .testSqlResult("f2 LIKE '%!_s%' ESCAPE '!'", true,
DataTypes.BOOLEAN())
+
+ // Escaped _ in quick path: multi-segment
(ChainChecker)
+ .testSqlResult("f2 LIKE 'te!_%st' ESCAPE '!'", true,
DataTypes.BOOLEAN())
+ .testSqlResult("f0 LIKE 'te!_%st' ESCAPE '!'", false,
DataTypes.BOOLEAN())
Review Comment:
At present, this is not a bug fix, but a technical debt
These tests are designed to increase the coverage of the tests and cover the
modified parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
