wenshao commented on code in PR #4362:
URL: https://github.com/apache/flink-cdc/pull/4362#discussion_r3043299572
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/options/JdbcSourceOptions.java:
##########
@@ -110,4 +110,11 @@ public class JdbcSourceOptions extends SourceOptions {
.withDescription(
"The chunk key of table snapshot, captured tables
are split into multiple chunks by a chunk key when read the snapshot of table."
+ "By default, the chunk key is the first
column of the primary key and the chunk key is the RowId in oracle.");
+
+ public static final ConfigOption<Double> RECORDS_PER_SECOND =
+ ConfigOptions.key("records.per.second")
+ .doubleType()
+ .defaultValue(-1d)
+ .withDescription(
+ "The maximum size of data processed per second,
the default value: -1, not limited");
Review Comment:
**[Suggestion]** Option description says "maximum size of data" but should
say "maximum number of records"
The description says `"The maximum size of data processed per second, the
default value: -1, not limited"` but the option is named `records.per.second`
and controls record count, not byte size. This misleading description is
replicated across all 6 `*Options` classes.
**Suggested fix:** Change to `"The maximum number of records emitted per
second. A negative value (default: -1) means no rate limiting."`
_— Qwen Code /review_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
