uicosp commented on code in PR #3776:
URL: https://github.com/apache/flink-cdc/pull/3776#discussion_r3056141711


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
##########
@@ -242,12 +243,24 @@ private void createDataEventsForTable(
         long exportStart = clock.currentTimeInMillis();
         LOG.info("Exporting data from split '{}' of table {}", 
snapshotSplit.splitId(), table.id());
 
+        String filter =
+                SnapshotFilterUtils.getSnapshotFilter(
+                        sourceConfig.getSnapshotFilters(), table.id());

Review Comment:
   Optimized filter lookup in commit 9e8b5f5:
   - Moved snapshot filter resolution from                          
     createDataEventsForTable() to the constructor of                   
     MySqlSnapshotSplitReadTask.
   - The filter is now computed once and stored as a class member   
     variable (snapshotFilter), avoiding repeated lookups on every      
     method invocation.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to