nishita-09 commented on code in PR #1000:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1000#discussion_r3056509995
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentContext.java:
##########
@@ -59,7 +59,9 @@ public Configuration getDeployConfig(AbstractFlinkSpec spec) {
@Override
protected Configuration createObserveConfig() {
- return configManager.getObserveConfig(getResource());
+ Configuration conf = configManager.getObserveConfig(getResource());
Review Comment:
Here, I have added it as a subsequent step that it specifically applies
overrides after getting default configs. We can have this incorporated in the
getObserveConfig as well and the getDeployConfig as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
