Izeren commented on code in PR #27904:
URL: https://github.com/apache/flink/pull/27904#discussion_r3057971213
##########
flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java:
##########
@@ -435,4 +435,37 @@ void testS3AWithSSEConfiguration() throws Exception {
assertThat(fs).isNotNull();
assertThat(fs).isInstanceOf(NativeS3FileSystem.class);
}
+
+ @Test
+ void testCustomTimeoutConfiguration() throws Exception {
Review Comment:
We should have some negative testing for incorrect values too
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -203,6 +204,44 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
+ "Uses the AWS SDK's default retry
strategy (exponential backoff with jitter). "
+ "Set to 0 to disable retries.");
+ public static final ConfigOption<Integer> CONNECTION_TIMEOUT =
Review Comment:
Can we use Duration for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
