Copilot commented on code in PR #4373:
URL: https://github.com/apache/flink-cdc/pull/4373#discussion_r3062148327
##########
docs/content/docs/connectors/flink-sources/postgres-cdc.md:
##########
@@ -219,7 +219,7 @@ SELECT * FROM shipments;
(1) source can be parallel during snapshot reading,
(2) source can perform checkpoints in the chunk granularity
during snapshot reading,
(3) source doesn't need to acquire global read lock (FLUSH
TABLES WITH READ LOCK) before snapshot reading.
- Please see <a href="#incremental-snapshot-reading ">Incremental
Snapshot Reading</a>section for more detailed information.
+ Please see <a href="#incremental-snapshot-reading-experimental
">Incremental Snapshot Reading</a>section for more detailed information.
Review Comment:
The fragment identifier in this link has a trailing space
(`#incremental-snapshot-reading-experimental `). In HTML, the space becomes
part of the fragment and won’t match the generated heading id, so the link will
not navigate correctly. Please remove the trailing space so it matches the
`Incremental Snapshot Reading (Experimental)` section id.
```suggestion
Please see <a
href="#incremental-snapshot-reading-experimental">Incremental Snapshot
Reading</a>section for more detailed information.
```
##########
docs/content/docs/connectors/flink-sources/mysql-cdc.md:
##########
@@ -658,7 +658,7 @@ The CDC job may restart fails in this case. So the
heartbeat event will help upd
When the MySQL CDC source is started, it reads snapshot of table parallelly
and then reads binlog of table with single parallelism.
In snapshot phase, the snapshot is cut into multiple snapshot chunks according
to chunk key of table and the size of table rows.
-Snapshot chunks is assigned to multiple snapshot readers. Each snapshot reader
reads its received chunks with [chunk reading
algorithm](#snapshot-chunk-reading) and send the read data to downstream.
+Snapshot chunks is assigned to multiple snapshot readers. Each snapshot reader
reads its received chunks with [chunk reading
algorithm](#Chunk-Reading-Algorithm) and send the read data to downstream.
Review Comment:
The link target `#Chunk-Reading-Algorithm` does not match the heading id
generated for `##### Chunk Reading Algorithm` (Hugo/Markdown heading ids are
typically lowercased, i.e., `#chunk-reading-algorithm`). With the current
capitalization, the internal link is likely broken. Please use the correct
generated fragment for that heading.
```suggestion
Snapshot chunks is assigned to multiple snapshot readers. Each snapshot
reader reads its received chunks with [chunk reading
algorithm](#chunk-reading-algorithm) and send the read data to downstream.
```
##########
docs/content.zh/docs/connectors/flink-sources/postgres-cdc.md:
##########
@@ -222,7 +222,7 @@ Connector Options
(1) source can be parallel during snapshot reading,
(2) source can perform checkpoints in the chunk granularity
during snapshot reading,
(3) source doesn't need to acquire global read lock (FLUSH
TABLES WITH READ LOCK) before snapshot reading.
- Please see <a href="#incremental-snapshot-reading ">Incremental
Snapshot Reading</a>section for more detailed information.
+ Please see <a href="#incremental-snapshot-reading-experimental
">Incremental Snapshot Reading</a>section for more detailed information.
Review Comment:
The fragment identifier in this link has a trailing space
(`#incremental-snapshot-reading-experimental `). This prevents matching the
generated heading id for `Incremental Snapshot Reading (Experimental)`, so the
link will not work. Please remove the trailing space from the fragment.
```suggestion
Please see <a
href="#incremental-snapshot-reading-experimental">Incremental Snapshot
Reading</a>section for more detailed information.
```
##########
docs/content/docs/connectors/flink-sources/oceanbase-cdc.md:
##########
@@ -854,7 +854,7 @@ Data Type Mapping
</td>
<td>
The spatial data types will be converted into STRING with a fixed Json
format.
- Please see <a href="#patial-data-types-mapping ">Spatial Data Types
Mapping</a> section for more detailed information.
+ Please see <a href="#Spatial-Data-Types-Mapping ">Spatial Data Types
Mapping</a> section for more detailed information.
Review Comment:
This link uses `href="#Spatial-Data-Types-Mapping "` with capital letters
and a trailing space. The `### Spatial Data Types Mapping` heading will
generate an id like `#spatial-data-types-mapping` (lowercase, no trailing
space), so the current fragment likely won’t resolve. Please update the
fragment to match the generated heading id and remove the trailing space.
```suggestion
Please see <a href="#spatial-data-types-mapping">Spatial Data Types
Mapping</a> section for more detailed information.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
