rkhachatryan commented on code in PR #27917:
URL: https://github.com/apache/flink/pull/27917#discussion_r3072240271
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java:
##########
@@ -246,9 +251,10 @@ private String retrieveCheckpointIfNeeded(
}
private StreamGraph getStreamGraph(UnalignedSettings settings,
Configuration conf) {
- // a dummy environment used to retrieve the DAG, mini cluster will be
used later
+ // Use getExecutionEnvironment so that TestStreamEnvironment's
randomizeConfiguration
+ // is triggered when the factory is registered (after
miniCluster.before()).
final StreamExecutionEnvironment setupEnv =
- StreamExecutionEnvironment.createLocalEnvironment(conf);
+ StreamExecutionEnvironment.getExecutionEnvironment(conf);
Review Comment:
I wonder how many other tests use Local Environment instead of Test
Environment unintentionally.
Maybe we should add javadoc to `createLocalEnvironment` or something more
sophisticated (like logging a warning if executing under junit).
(this is unrelated to this PR though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
