snuyanzin commented on code in PR #27929:
URL: https://github.com/apache/flink/pull/27929#discussion_r3081236149
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableImpl.java:
##########
@@ -878,36 +875,52 @@ private static final class PartitionedTableImpl
implements PartitionedTable {
private final TableImpl table;
private final List<Expression> partitionKeys;
+ private final List<Expression> orderKeys;
private PartitionedTableImpl(TableImpl table, List<Expression>
partitionKeys) {
+ this(table, partitionKeys, Collections.emptyList());
+ }
+
+ private PartitionedTableImpl(
+ TableImpl table, List<Expression> partitionKeys,
List<Expression> orderKeys) {
this.table = table;
this.partitionKeys = partitionKeys;
+ this.orderKeys = orderKeys;
+ }
+
+ @Override
+ public PartitionedTable orderBy(Expression... fields) {
Review Comment:
```suggestion
public PartitionedTable orderBy(Expression... expressions) {
```
in general it could be not only fields, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
