och5351 commented on code in PR #27891: URL: https://github.com/apache/flink/pull/27891#discussion_r3085072693
########## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/rescales/JobRescalesOverviewHandler.java: ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.handler.job.rescales; + +import org.apache.flink.configuration.JobManagerOptions; +import org.apache.flink.configuration.WebOptions; +import org.apache.flink.runtime.rest.handler.HandlerRequest; +import org.apache.flink.runtime.rest.handler.RestHandlerException; +import org.apache.flink.runtime.rest.handler.job.AbstractExecutionGraphHandler; +import org.apache.flink.runtime.rest.handler.legacy.ExecutionGraphCache; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.ErrorResponseBody; +import org.apache.flink.runtime.rest.messages.JobIDPathParameter; +import org.apache.flink.runtime.rest.messages.JobMessageParameters; +import org.apache.flink.runtime.rest.messages.MessageHeaders; +import org.apache.flink.runtime.rest.messages.ResponseBody; +import org.apache.flink.runtime.rest.messages.job.rescales.JobRescalesOverview; +import org.apache.flink.runtime.rest.messages.job.rescales.JobRescalesOverviewHeaders; +import org.apache.flink.runtime.scheduler.ExecutionGraphInfo; +import org.apache.flink.runtime.webmonitor.RestfulGateway; +import org.apache.flink.runtime.webmonitor.history.ArchivedJson; +import org.apache.flink.runtime.webmonitor.history.JsonArchivist; +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever; + +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus; + +import java.io.IOException; +import java.time.Duration; +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.concurrent.Executor; + +/** Handler to respond with a job rescales overview. */ +public class JobRescalesOverviewHandler + extends AbstractExecutionGraphHandler<JobRescalesOverview, JobMessageParameters> + implements JsonArchivist { + + public JobRescalesOverviewHandler( + GatewayRetriever<? extends RestfulGateway> leaderRetriever, + Duration timeout, + Map<String, String> responseHeaders, + MessageHeaders<EmptyRequestBody, JobRescalesOverview, JobMessageParameters> + messageHeaders, + ExecutionGraphCache executionGraphCache, + Executor executor) { + super( + leaderRetriever, + timeout, + responseHeaders, + messageHeaders, + executionGraphCache, + executor); + } + + @Override + protected JobRescalesOverview handleRequest( + HandlerRequest<EmptyRequestBody> request, ExecutionGraphInfo executionGraphInfo) + throws RestHandlerException { + return getJobRescalesOverview(executionGraphInfo); + } + + private JobRescalesOverview getJobRescalesOverview(ExecutionGraphInfo executionGraphInfo) + throws RestHandlerException { + if (executionGraphInfo.getRescalesStatsSnapshot() == null Review Comment: How about use a local variable? RescalesStatsSnapshot rescalesStatsSnapshot() = executionGraphInfo.getRescalesStatsSnapshot(); ########## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/rescales/JobRescalesOverviewHeaders.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.messages.job.rescales; + +import org.apache.flink.runtime.rest.HttpMethodWrapper; +import org.apache.flink.runtime.rest.handler.job.rescales.JobRescalesOverviewHandler; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.JobMessageParameters; +import org.apache.flink.runtime.rest.messages.RuntimeMessageHeaders; + +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus; + +/** Headers for {@link JobRescalesOverviewHandler}. */ +public class JobRescalesOverviewHeaders + implements RuntimeMessageHeaders< + EmptyRequestBody, JobRescalesOverview, JobMessageParameters> { + public static final JobRescalesOverviewHeaders INSTANCE = new JobRescalesOverviewHeaders(); + public static final String JOB_RESCALES_OVERVIEW_PATH = "/jobs/:jobid/rescales/overview"; + + @Override + public Class<JobRescalesOverview> getResponseClass() { + return JobRescalesOverview.class; + } + + public HttpResponseStatus getResponseStatusCode() { + return HttpResponseStatus.OK; + } + + public String getDescription() { Review Comment: Here too. ########## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/rescales/JobRescalesOverviewHeaders.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.messages.job.rescales; + +import org.apache.flink.runtime.rest.HttpMethodWrapper; +import org.apache.flink.runtime.rest.handler.job.rescales.JobRescalesOverviewHandler; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.JobMessageParameters; +import org.apache.flink.runtime.rest.messages.RuntimeMessageHeaders; + +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus; + +/** Headers for {@link JobRescalesOverviewHandler}. */ +public class JobRescalesOverviewHeaders + implements RuntimeMessageHeaders< + EmptyRequestBody, JobRescalesOverview, JobMessageParameters> { + public static final JobRescalesOverviewHeaders INSTANCE = new JobRescalesOverviewHeaders(); + public static final String JOB_RESCALES_OVERVIEW_PATH = "/jobs/:jobid/rescales/overview"; + + @Override + public Class<JobRescalesOverview> getResponseClass() { + return JobRescalesOverview.class; + } + + public HttpResponseStatus getResponseStatusCode() { Review Comment: Could you please add @Override annotation for consistency like JobRescaleDetailsHeaders, JobRescalesHistoryHeaders? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
