gustavodemorais commented on code in PR #27935:
URL: https://github.com/apache/flink/pull/27935#discussion_r3092557088
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionTestPrograms.java:
##########
@@ -1072,8 +1073,8 @@ public class ProcessTableFunctionTestPrograms {
"+I[Bob, {Processing input row
+I[Bob, 4, 1970-01-01T00:00:00.004Z] at time 4 watermark null},
1970-01-01T00:00:00.004Z]",
"+I[Bob, {Processing input row
+I[Bob, 5, 1970-01-01T00:00:00.005Z] at time 5 watermark null},
1970-01-01T00:00:00.005Z]",
"+I[Bob, {Processing input row
+I[Bob, 6, 1970-01-01T00:00:00.006Z] at time 6 watermark null},
1970-01-01T00:00:00.006Z]",
- "+I[Bob, {Timer timeout2 fired at
time 2 watermark 9223372036854775807}, 1970-01-01T00:00:00.002Z]",
- "+I[Bob, {Clearing all timers at
time 2 watermark 9223372036854775807}, 1970-01-01T00:00:00.002Z]")
+ "+I[Bob, {Timer timeout2 fired at
time 5 watermark 9223372036854775807}, 1970-01-01T00:00:00.005Z]",
Review Comment:
Nice, this is basically the bugfix, right? We were incorrectly firing
timeout2 at 2 and now we fire corrently at 5
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionTestPrograms.java:
##########
Review Comment:
One thing that was a bit confusing for me is why we have watermark
9223372036854775807 here? Do we emit this max watermark only for testing or do
our sources actually emit this when all values have been read? I wondered if
that basically makes the user not know if something is late anymore since
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
