spuru9 commented on code in PR #27892:
URL: https://github.com/apache/flink/pull/27892#discussion_r3093663137
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/rescales/JobRescalesOverviewHandler.java:
##########
@@ -81,14 +82,7 @@ private JobRescalesOverview
getJobRescalesOverview(ExecutionGraphInfo executionG
throws RestHandlerException {
RescalesStatsSnapshot rescalesStatsSnapshot =
executionGraphInfo.getRescalesStatsSnapshot();
if (rescalesStatsSnapshot == null ||
rescalesStatsSnapshot.getRescaleHistory() == null) {
- throw new RestHandlerException(
- String.format(
- "The job `%s` has not enabled the `%s` scheduler,
or it has been enabled but the value of configuration option `%s` has not been
set to greater than `0`.",
- executionGraphInfo.getJobId(),
- JobManagerOptions.SchedulerType.Adaptive,
-
WebOptions.MAX_ADAPTIVE_SCHEDULER_RESCALE_HISTORY_SIZE.key()),
- HttpResponseStatus.NOT_FOUND,
- RestHandlerException.LoggingBehavior.IGNORE);
+ throw newRestHandlerException(executionGraphInfo.getJobId());
Review Comment:
nit: newRestHandlerException describes the return type, not the failure
condition. newRescalesUnavailableException would be clearer. Also, a shared
error factory feels out of place on JobRescalesOverviewHandler — sibling
handlers shouldn't need to import from a peer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
