twalthr commented on code in PR #27929:
URL: https://github.com/apache/flink/pull/27929#discussion_r3094509899


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/TableSemantics.java:
##########
@@ -116,4 +127,40 @@ public interface TableSemantics {
      *     type inference phase as the changelog mode is still unknown.
      */
     Optional<ChangelogMode> changelogMode();
+
+    /** The sort direction for ORDER BY columns in table arguments with set 
semantics. */
+    @PublicEvolving
+    enum SortDirection {
+        /** Ascending order with nulls first. */
+        ASC_NULLS_FIRST(false, true),

Review Comment:
   The timestamp is not nullable. But the interfaces here just reflect SQL 
semantics. Even if not specified explicitly, you will get some implicit null 
behavior from the engine. And TableSemantics class will reflect this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to