wenjin272 commented on PR #546: URL: https://github.com/apache/flink-agents/pull/546#issuecomment-4266003277
### Code review Found 1 issue: 1. Dead code: `ActionTaskContextManager.getResource(String, ResourceType, ResourceCache)` is defined but never called. The original `getResource` helper in `ActionExecutionOperator` was invoked via method reference when constructing `JavaResourceAdapter`; after the extraction, the callers in `PythonBridgeManager` inline `resourceCache.getResource(name, type)` directly (see `PythonBridgeManager.java` [L105-L109](https://github.com/apache/flink-agents/blob/78a1219b20ec164a9bdc07c82d65feb7d18fc921/runtime/src/main/java/org/apache/flink/agents/runtime/operator/PythonBridgeManager.java#L105-L109) and [L139-L143](https://github.com/apache/flink-agents/blob/78a1219b20ec164a9bdc07c82d65feb7d18fc921/runtime/src/main/java/org/apache/flink/agents/runtime/operator/PythonBridgeManager.java#L139-L143)), so this wrapper has no remaining callers and can be removed. https://github.com/apache/flink-agents/blob/78a1219b20ec164a9bdc07c82d65feb7d18fc921/runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionTaskContextManager.java#L155-L163 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
