addu390 commented on code in PR #631:
URL: https://github.com/apache/flink-agents/pull/631#discussion_r3103830905
##########
api/src/main/java/org/apache/flink/agents/api/Event.java:
##########
@@ -19,36 +19,76 @@
package org.apache.flink.agents.api;
import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.io.IOException;
import java.util.HashMap;
import java.util.Map;
import java.util.Objects;
import java.util.UUID;
/** Base class for all event types in the system. */
-public abstract class Event {
+public class Event {
+
+ private static final ObjectMapper MAPPER = new ObjectMapper();
+
private final UUID id;
+ private final String type;
private final Map<String, Object> attributes;
/** The timestamp of the source record. */
private Long sourceTimestamp;
Review Comment:
`sourceTimestamp` seems to be used in runtime for timestamp propagation
(`ActionExecutionOperator`, `RunnerContextImpl`, `JavaActionTask`, etc.). Safe
to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
