raminqaf commented on code in PR #27973:
URL: https://github.com/apache/flink/pull/27973#discussion_r3109445354
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/FromChangelogFunction.java:
##########
@@ -137,7 +137,10 @@ public void eval(
final StringData opCode = input.getString(opColumnIndex);
final RowKind rowKind = opMap.get(opCode);
if (rowKind == null) {
- return;
+ throw new RuntimeException(
Review Comment:
In the FLIP it is mentioned that we throw `ValidationException` at this
point.
https://cwiki.apache.org/confluence/display/FLINK/FLIP-564%3A+Support+FROM_CHANGELOG+and+TO_CHANGELOG+built-in+PTFs#431-invalid-operation-codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
