Au-Miner commented on code in PR #27827:
URL: https://github.com/apache/flink/pull/27827#discussion_r3115533055
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MultiJoinTestPrograms.java:
##########
@@ -133,6 +133,56 @@ public class MultiJoinTestPrograms {
+ "INNER JOIN Payments p ON u.user_id =
p.user_id")
.build();
+ public static final TableTestProgram
MULTI_JOIN_THREE_WAY_INNER_JOIN_WITH_IS_NOT_DISTINCT =
Review Comment:
The new semantic test lacks a state recovery scenario, and testing can be
added in `MultiJoinRestoreTest`
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MultiJoinTestPrograms.java:
##########
@@ -133,6 +133,56 @@ public class MultiJoinTestPrograms {
+ "INNER JOIN Payments p ON u.user_id =
p.user_id")
.build();
+ public static final TableTestProgram
MULTI_JOIN_THREE_WAY_INNER_JOIN_WITH_IS_NOT_DISTINCT =
+ TableTestProgram.of(
+ "three-way-inner-join-with-is-not-distinct",
+ "three way inner join with is not distinct")
+
.setupConfig(OptimizerConfigOptions.TABLE_OPTIMIZER_MULTI_JOIN_ENABLED, true)
Review Comment:
Aligning with other MultiJoinSemanticTests#programs,
`.setupConfig(OptimizerConfigOptions.TABLE_OPTIMIZER_MULTI_JOIN_ENABLED, true)`
can be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
