twalthr commented on code in PR #27975:
URL: https://github.com/apache/flink/pull/27975#discussion_r3115894222


##########
flink-python/pyflink/table/table.py:
##########
@@ -1220,6 +1220,40 @@ def to_changelog(self, *arguments: Expression) -> 
'Table':
         """
         return 
Table(self._j_table.toChangelog(to_expression_jarray(arguments)), self._t_env)
 
+    def from_changelog(self, *arguments: Expression) -> 'Table':
+        """
+        Converts this append-only table with an explicit operation code column 
into a
+        dynamic table using the built-in ``FROM_CHANGELOG`` process table 
function.
+
+        Each input row is expected to have a string operation code column 
(default: ``op``)
+        that indicates the change operation (e.g., INSERT, UPDATE_AFTER, 
UPDATE_BEFORE,
+        DELETE). The output table is a dynamic table backed by a changelog 
stream.

Review Comment:
   ```
   Converts this append-only table with an explicit operation code column into 
a (potentially updating) dynamic table. Each input row is expected to have a 
string column that indicates the change operation. The operation column is 
interpreted by the engine and removed from the output.
   ```
   Can we stay closer to the website docs we agreed upon? Maybe also update 
JavaDoc accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to