davidradl commented on code in PR #32:
URL:
https://github.com/apache/flink-connector-http/pull/32#discussion_r3116072794
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpLookupConnectorOptions.java:
##########
@@ -227,4 +229,24 @@ public class HttpLookupConnectorOptions {
+ "Ignored responses togater with `"
+ SOURCE_RETRY_SUCCESS_CODES
+ "` are considered as successful.");
+
+ /**
+ * Custom HTTP headers for lookup requests.
+ *
+ * <p>Headers are specified as key-value pairs using the prefix {@code
+ * http.source.lookup.header.}, for example:
+ *
+ * <pre>{@code
+ * 'http.source.lookup.header.Content-Type' = 'application/json',
+ * 'http.source.lookup.header.Authorization' = 'Bearer my-token'
+ * }</pre>
+ */
+ public static final ConfigOption<Map<String, String>>
SOURCE_LOOKUP_HEADERS =
Review Comment:
@featzhang that makes sense- we just need to be careful about precedence and
to give recommended ways of configuring. i.e. recommend the new option for the
reasons you say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
