wenjin272 commented on PR #634: URL: https://github.com/apache/flink-agents/pull/634#issuecomment-4287624673
### Code review Found 1 issue: 1. The fix is Java-only — the Python `ChatModelAction` has the same bug and was not updated. `python/flink_agents/plan/actions/chat_model_action.py` still calls `json.loads(response.content.strip())` with no fence stripping, so the same `JSONDecodeError` will occur for fenced LLM responses on the Python path. This module has historically required Java/Python parity (e.g. PR #548 was held until the Python side was updated), so reviewers will likely ask for a parallel `_clean_llm_response` helper here. https://github.com/apache/flink-agents/blob/18f2803bfc11758a925778ad686ee2e5d5d4de31/python/flink_agents/plan/actions/chat_model_action.py#L199-L203 For reference, the new Java helper added in this PR: https://github.com/apache/flink-agents/blob/18f2803bfc11758a925778ad686ee2e5d5d4de31/plan/src/main/java/org/apache/flink/agents/plan/actions/ChatModelAction.java#L205-L221 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
