featzhang commented on PR #30: URL: https://github.com/apache/flink-connector-http/pull/30#issuecomment-4290375374
Hi @davidradl, Thank you for the detailed review! I have addressed all the issues you raised in the commits pushed on **March 31, 2026**: ### ✅ Issues Fixed: 1. **Connector name for HTTP Sink** ([2118b39](https://github.com/apache/flink-connector-http/pull/30/commits/2118b39), [db7e3df](https://github.com/apache/flink-connector-http/pull/30/commits/db7e3df)) - Fixed: `'http-sink'` → `'http-async-sink'` - Matches `HttpDynamicTableSinkFactory.IDENTIFIER` in the code 2. **Connector name for HTTP Lookup Source** (already correct in [7698996](https://github.com/apache/flink-connector-http/pull/30/commits/7698996)) - Using: `'connector' = 'http'` - Matches `HttpLookupTableSourceFactory.IDENTIFIER` in the code 3. **README.md** - No modifications to README.md (kept lightweight, following Kafka connector style ✓) 4. **Configuration Options Table** - Removed duplicate "Common Configuration Options" table - Quick Start examples now reference detailed sections below for full options ### 📝 Current Structure: The Quick Start section in `docs/content/docs/connectors/table/http.md` (and Chinese version) now includes: - SQL Example for HTTP Sink (using `http-async-sink`) - SQL Example for HTTP Lookup Source (using `http`) - DataStream API Example for HTTP Sink - All examples point to detailed configuration sections in the docs ### ✅ Verification: - Confirmed connector identifiers match the factory classes in code - DataStream API example uses correct HttpSink.builder() API - Markdown format validated - CI passing on Java 11 & 17 Could you please take another look when you have a chance? All your feedback has been incorporated. Thank you! 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
