spuru9 commented on code in PR #27991:
URL: https://github.com/apache/flink/pull/27991#discussion_r3120092666
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -186,7 +187,8 @@ public ExecutionGraph createAndRestoreExecutionGraph(
if (checkpointCoordinator != null) {
// check whether we find a valid checkpoint
if (!checkpointCoordinator.restoreInitialCheckpointIfPresent(
- new
HashSet<>(newExecutionGraph.getAllVertices().values()))) {
+ new HashSet<>(newExecutionGraph.getAllVertices().values()),
+
configuration.get(SavepointConfigOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE))) {
Review Comment:
`SavepointConfigOptions` was removed as part of 2.0 release
https://github.com/apache/flink/blob/937325653695881e8737816ba40b46fa0819dd21/docs/content/release-notes/flink-2.0.md?plain=1#L373
Can you check an alternative.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorRestoringTest.java:
##########
@@ -1113,7 +1113,7 @@ void testRestoreFinishedStateWithoutInFlightData() throws
Exception {
.build(graph);
ExecutionJobVertex vertex = graph.getJobVertex(jobVertexID);
- coord.restoreInitialCheckpointIfPresent(Collections.singleton(vertex));
+ coord.restoreInitialCheckpointIfPresent(Collections.singleton(vertex),
false);
Review Comment:
Can you add tests for allowNonRestoredState=true (mentioned in PR
description).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
