Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3121241880
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -271,6 +286,7 @@ public int getPriority() {
@Override
public void configure(Configuration config) {
this.flinkConfig = config;
+ this.bucketConfigProvider = new BucketConfigProvider(config);
Review Comment:
Both fields are null before configure() is called. flinkConfig is also
effectively nullable (see the if (config == null) fallback in create()), it
just wasn't annotated. `@Nullable` on bucketConfigProvider makes the contract
explicit since create() null-checks it before applying overrides.
i have added `@Nullable` to flinkConfig for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
