gaborgsomogyi commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3123344969
##########
flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java:
##########
@@ -594,4 +594,166 @@ void testInvalidTimeoutConfigurationThrowsException() {
assertThatThrownBy(() -> factory.create(fsUri))
.isInstanceOf(IllegalArgumentException.class);
}
+
+ // ---- Bucket-level configuration tests ----
+
+ @Test
+ void testCreateFileSystemWithBucketSpecificEndpoint() throws Exception {
Review Comment:
Tests which are testing that fs is not null and `NativeS3FileSystem` is not
super extensive and repetitive. We need to find out what we really want to test
here because if I would add totally garbage configs as input I presume the fs
instance will be also created. I'm not saying to drop them but we must find
what these tests are covering. If we know that we can act accordingly. Maybe we
just check the fs config somehow? No in-depth consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
