featzhang commented on PR #35: URL: https://github.com/apache/flink-connector-http/pull/35#issuecomment-4298076937
✅ **Refactored per your feedback** Thank you for the guidance! I've refactored the PR to integrate error logging into the existing `HttpLogger` instead of creating a separate system. **Changes made**: - ❌ Removed `HttpErrorLogger` class entirely - ✅ Extended `HttpLogger` with new `http.error.log.severity` config - ✅ Enhanced `logLookupError()` and `logSinkError()` to respect severity level - ✅ Maintained `http.logging.level` (MIN/REQ_RESP/MAX) for content verbosity - ✅ Two orthogonal dimensions as discussed **Configuration**: ```java http.logging.level // MIN/REQ_RESP/MAX (content detail) http.error.log.severity // OFF/ERROR/WARN/INFO (log level) ``` **Behavior**: - `continue-on-error=false`: Logs at configured severity (default: ERROR) - `continue-on-error=true`: Always DEBUG (error is tolerated) - Default: `http.error.log.severity=ERROR` (production-friendly) - Set to `OFF` for current behavior (DEBUG only) **Backward compatible**: Default behavior unchanged unless user explicitly sets `http.error.log.severity`. **Removed old config options**: - `http.error.log.level` → replaced by `http.error.log.severity` - `http.error.log.include.body` → now controlled by `http.logging.level` - `http.error.log.body.max.size` → using built-in default Let me know if this aligns with your vision! Happy to adjust further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
