ferenc-csaky commented on code in PR #28009:
URL: https://github.com/apache/flink/pull/28009#discussion_r3131859477
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3ClientProvider.java:
##########
@@ -102,6 +112,11 @@ private S3ClientProvider(
this.connectionTimeout = connectionTimeout;
this.socketTimeout = socketTimeout;
this.connectionMaxIdleTime = connectionMaxIdleTime;
+ this.pathStyleAccess = pathStyleAccess;
Review Comment:
I don't really agree. Having a config record would just move this long param
list into the record definition, so I don't think that would help. In general
this is a private ctor, with a public facing builder, so we can have an ugly
ctor, it's internal. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
