autophagy commented on code in PR #27048:
URL: https://github.com/apache/flink/pull/27048#discussion_r3137183283
##########
flink-python/src/main/java/org/apache/flink/api/common/python/PythonBridgeUtils.java:
##########
@@ -193,6 +195,12 @@ private static Object getPickledBytesFromJavaObject(Object
obj, LogicalType data
} else {
return pickler.dumps(obj);
}
+ } else if (dataType instanceof LocalZonedTimestampType) {
Review Comment:
@davidradl Sorry for dropping this PR! Thank you for the feedback. I've
added some tests at the Java level to test the pickling actually works.
On the second point, I'm not so sure! The session timezone setting
(`table.local-time-zone`) seems to only affects SQL display, and not what gets
returned during `collect()`. Both Java and Python return the raw absolute
instant (the former returns a `java.time.Instant`, the latter a naive datetime
capturing the same instant).
The pickle bridge transfers epoch microseconds, so the returned value is
timezone-agnostic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
