[ 
https://issues.apache.org/jira/browse/FLINK-39535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076080#comment-18076080
 ] 

Gabor Somogyi commented on FLINK-39535:
---------------------------------------

I would check at least the following:
- Copy-paste parts
- Tests without assertions
- Tests where I change signification parts and still pass (an example where fs 
!= null is checked, if we delete sent params or add any custom params it still 
passing)

Maybe there are more to check, not analyzed it through

> Improve Unit Test & coverage 
> -----------------------------
>
>                 Key: FLINK-39535
>                 URL: https://issues.apache.org/jira/browse/FLINK-39535
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / FileSystem
>    Affects Versions: 2.3.0
>            Reporter: Samrat Deb
>            Priority: Major
>             Fix For: 2.4.0
>
>
> Currently, there is a lot of repetition, and there is a scope to improve 
> tests standards in native s3 fs. 
> Revisit all tests in Native S3 FS and improve it 
> Suggestion from [~gaborgsomogyi]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to