pelaezryan commented on PR #243:
URL:
https://github.com/apache/flink-connector-aws/pull/243#issuecomment-4315070513
Added unit tests.
Verified test failed when i reverted my fix:
```
org.opentest4j.AssertionFailedError:
expected: 1
but was: 16385
Expected :1
Actual :16385
<Click to see difference>
at
java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
at
org.apache.flink.connector.kinesis.source.reader.fanout.FanOutKinesisShardSubscriptionTest.testOnCompleteDoesNotResubscribe(FanOutKinesisShardSubscriptionTest.java:209)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
