featzhang commented on PR #27560: URL: https://github.com/apache/flink/pull/27560#issuecomment-4322279155
Updated PR title: changed module tag from `[model]` to `[table]` to accurately reflect the actual modified module (`flink-table/flink-table-common`), not `flink-models`. This PR fully implements [FLINK-39059](https://issues.apache.org/jira/browse/FLINK-39059) acceptance criteria: - ✅ Metrics auto-registered in base classes — no changes required in subclasses (OpenAI/Triton/etc.) - ✅ Consistent exposure across `PredictFunction` and `AsyncPredictFunction` via shared `PredictFunctionMetrics` - ✅ All five metrics implemented: `requests`, `requests_success`, `requests_failure`, `latency` (histogram), `rows_output` - ✅ Extensibility hook `createLatencyHistogram(MetricGroup)` provided for custom bucket configuration - ✅ Metric naming follows Flink conventions (no `inference_` prefix on registered names) - ✅ Unit tests added in `PredictFunctionTest` covering success/failure/null/empty/custom-histogram paths - ✅ No regression — wrapper logic only, existing inference behavior unchanged CI is green: Azure build [#73198](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=73198) SUCCESS @ c4562bd4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
