rkhachatryan commented on code in PR #27783:
URL: https://github.com/apache/flink/pull/27783#discussion_r3144159414
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java:
##########
@@ -95,23 +105,57 @@ public void recover(
InputChannelInfo channelInfo,
int oldSubtaskIndex,
BufferWithContext<Buffer> bufferWithContext)
- throws IOException {
+ throws IOException, InterruptedException {
Buffer buffer = bufferWithContext.context;
try {
if (buffer.readableBytes() > 0) {
RecoveredInputChannel channel = getMappedChannels(channelInfo);
- channel.onRecoveredStateBuffer(
- EventSerializer.toBuffer(
- new SubtaskConnectionDescriptor(
- oldSubtaskIndex,
channelInfo.getInputChannelIdx()),
- false));
- channel.onRecoveredStateBuffer(buffer.retainBuffer());
+
+ if (filteringHandler != null) {
+ recoverWithFiltering(
+ channel, channelInfo, oldSubtaskIndex,
buffer.retainBuffer());
+ } else {
+ channel.onRecoveredStateBuffer(
+ EventSerializer.toBuffer(
+ new SubtaskConnectionDescriptor(
+ oldSubtaskIndex,
channelInfo.getInputChannelIdx()),
+ false));
Review Comment:
Why don't we need to emit `SubtaskConnectionDescriptor` in the branch above
(`recoverWithFiltering`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
