Izeren commented on code in PR #27989:
URL: https://github.com/apache/flink/pull/27989#discussion_r3147163899
##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/metrics/otel/OpenTelemetryMetricReporter.java:
##########
@@ -156,6 +166,7 @@ protected MetricExporter createExporter(final MetricConfig
metricConfig) {
@Override
public synchronized void close() {
+ transformer = null;
Review Comment:
I would argue that nulling is a bit better as we ultimately don't want this
class any more, but just for null safety it makes sense to me. Added a `reset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
