1996fanrui commented on code in PR #28001:
URL: https://github.com/apache/flink/pull/28001#discussion_r3147301782
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java:
##########
@@ -162,6 +238,11 @@ public void close() throws IOException {
for (final InputGate inputGate : inputGates) {
inputGate.finishReadRecoveredState();
}
+ if (preFilterSegment != null) {
+ preFilterSegment.free();
+ preFilterSegment = null;
+ preFilterBufferInUse = false;
+ }
Review Comment:
no, we reset it as null after release, so it never be `double-released`.
Also:
- `preFilterSegment` is a reusable buffer, it is never released during
filtering.
- `preFilterBufferInUse` is only used for defensive programming to prevent a
single reusable buffer from being allocated multiple times simultaneously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
