jlalwani-amazon commented on PR #32: URL: https://github.com/apache/flink-connector-hive/pull/32#issuecomment-4330437808
Thanks for this fix — the root cause analysis is solid. Setting `HiveConf.hiveSiteLocation` to null in a static context affects all subsequent `HiveConf` instances in the JVM, which breaks other Hive-dependent libraries (Hudi, Iceberg, etc.). One thing I noticed: the same code block also modifies two other static fields that aren't being restored: ```java HiveConf.setHiveSiteLocation(null); // line 258 — your PR restores this ✅ HiveConf.setLoadMetastoreConfig(false); // line 259 — not restored ❌ HiveConf.setLoadHiveServer2Config(false); // line 260 — not restored ❌ ``` These have the same problem — they're static fields that affect all subsequent `HiveConf` instances in the JVM. If another library expects metastore or HiveServer2 config to be loaded from default locations, setting these to `false` without restoring them could cause similar issues. Should we save and restore all three for a complete fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
